Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting headers in order to have single modules functions #274

Closed
Rinnegatamante opened this issue Dec 29, 2017 · 5 comments
Closed

Splitting headers in order to have single modules functions #274

Rinnegatamante opened this issue Dec 29, 2017 · 5 comments
Labels

Comments

@Rinnegatamante
Copy link
Member

This is something required for properly implementing #124 .

At the moment we have some headers that actually contain functions from several modules like:

psp2/videodec.h having sceAvcdec and sceVideodec functions.
psp2/net/http.h having sceHttp and sceHttps functions.

Actually splitting headers shouldn't bother too much since the suggested way to use headers is actually to just include vitasdk.h without cherry picking headers.

@devnoname120
Copy link
Member

Actually splitting headers shouldn't bother too much since the suggested way to use headers is actually to just include vitasdk.h

Most people are not doing that, and we can't afford to break them.

@Rinnegatamante
Copy link
Member Author

That means we can't actually ship decent and accurated documentation due to some people preferring to make their life harder.

P.s. I don't see "most" people using these headers btw.
Majority of homebrews cherry picking headers are very old homebrews.
Also replacing such headers with vitasdk.h is an easy enough change even for a non developer.

@devnoname120
Copy link
Member

devnoname120 commented Dec 30, 2017

The drawbacks largely overwhelm the small benefit such a change would bring. We now avoid any kind of breaking changes unless it is absolutely necessary.

@yne
Copy link
Contributor

yne commented Dec 31, 2017

Fun fact, there is only 1 usage of the HTTPS Vita API on github:
https://github.com/Stary2001/vita-lua/blob/1a179629a9068f98154edbce87aef7b0537e826d/src/ffi/http.c

Issues like this should be resolved in a democratic way (it should be less frustrating for both sides).

Personally, I vote to split, because I'm the one that made a mistake back in the psp2sdk days (173210/psp2sdk@e72bf40) and I don't like doing mistakes.

@devnoname120
Copy link
Member

@CelesteBlue-dev Please abstain from calling people names, especially for no good reason.

@vitasdk vitasdk locked as too heated and limited conversation to collaborators Jan 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants