Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the benchmarks as part of github actions and fails PR if sees degradation #45

Open
frouioui opened this issue Mar 2, 2021 · 1 comment
Open

Add the benchmarks as part of github actions and fails PR if sees degradation #45

frouioui opened this issue Mar 2, 2021 · 1 comment
Labels
P2 Type: Feature Request

Comments

@frouioui
Copy link
Member

frouioui commented Mar 2, 2021

Allow PRs and commits in vitess to run a benchmarking job through GitHub Actions. This will allow us to verify the performance impacts of incoming changes.
@frouioui
Copy link
Member Author

There is now a comment added by the vitess bot that links the PR to the webpage where users can compare the PR's base and HEAD. Although, the PR is not marked as failed when there is a degradation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 Type: Feature Request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@frouioui