Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add more flexibility backing up/restoring from different backup engines. #16429

Open
rvrangel opened this issue Jul 18, 2024 · 1 comment · May be fixed by #16428
Open

Feature Request: Add more flexibility backing up/restoring from different backup engines. #16429

rvrangel opened this issue Jul 18, 2024 · 1 comment · May be fixed by #16428

Comments

@rvrangel
Copy link
Contributor

Feature Description

Today even though a vttablet can restore backups take from different backup engines, we can't change which backup engine we want to use unless we have tablets with different configuration in the same shard or changing it and restarting.

I would propose the following:

  • adding a field on the Backup() call to allow to pass which backup engine to use, so users can have all the flags and define a default backup engine, but are still able to override which backup engine to use in the Backup() call
  • adding a field on the RestoreFromBackup() call so backups from certain backup engines can be ignored when a tablet either starts for the first time or when received via its tabletamanger API`.

Use Case(s)

This will be interesting specially in combination with #16294 as it will allow for the particular scenario of being able to take both physical and logical backups, but always restoring physical backups by default. We would still be able to target a specific backup to be restored via and API call via its timestamp.

@rvrangel rvrangel added Type: Feature Request Needs Triage This issue needs to be correctly labelled and triaged labels Jul 18, 2024
@shlomi-noach shlomi-noach self-assigned this Jul 21, 2024
@shlomi-noach shlomi-noach added Component: Backup and Restore and removed Needs Triage This issue needs to be correctly labelled and triaged labels Jul 21, 2024
@shlomi-noach
Copy link
Contributor

I like this idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants