Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VReplication: allow overriding flags per-workflow and dynamically #16489

Open
rohit-nayak-ps opened this issue Jul 27, 2024 · 0 comments · May be fixed by #16583
Open

VReplication: allow overriding flags per-workflow and dynamically #16489

rohit-nayak-ps opened this issue Jul 27, 2024 · 0 comments · May be fixed by #16583

Comments

@rohit-nayak-ps
Copy link
Contributor

Feature Description

There are several flags that impact vreplication behaviour/performance that are currently scoped asvttablet flags (https://vitess.io/docs/reference/vreplication/flags/)

It is often useful to modify these when a workflow is running, for example relay_log_max_size, vreplication_copy_phase_duration, vreplication_experimental_flags, etc.

At the moment we need to roll vttablets if we want to modify these, after setting the flags appropriately. This is obviously not ideal. In addition, any changes affect all vreplication workflows.

We should add the ability to specify these creating a workflow, if a user wants to override the vttablet defaults, and where applicable let them be modified dynamically.

We will need API changes fo flags that are applicable at the source vstreamer level. So maybe we can start with the target related flags, to begin with.

We should also expose these values in the Workflow Show output, indicating if they are overrides, and allow modifying them in Workflow Update.

Use Case(s)

.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant