Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Retry vstream on a new tablet if an error is encountered #16535

Open
twthorn opened this issue Aug 5, 2024 · 0 comments
Open

Comments

@twthorn
Copy link
Contributor

twthorn commented Aug 5, 2024

Feature Description

vstream manager on vtgate will, for certain errors, always retry on the same tablet, and never switch to a new tablet. This means the vstream could be failing indefinitely for any error code that is not Invalid arg/GTID set mismatch. We have no guarantee that these are transient errors and we must try other tablets to provide higher availability of vstreams. We should simplify the retry logic and always try a new tablet if the one we attempted to set up a vstream fails. We will still prefer local cell (it is the first we try on restarts, and after the 3 retries are maxed out).

Use Case(s)

For cases where a user has a shard with a local cell tablet that keeps returning any error that is not GTID set mismatch, it will cause an outage/no data streamed. Adapt the retry algorithm so other tablets are tried on failure.

@twthorn twthorn added Needs Triage This issue needs to be correctly labelled and triaged Type: Feature Request labels Aug 5, 2024
@mattlord mattlord added Component: VReplication and removed Needs Triage This issue needs to be correctly labelled and triaged labels Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

2 participants