Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a fixed-width (either in time or number of samples) plot #42

Closed
vkottler opened this issue Nov 16, 2023 · 3 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@vkottler
Copy link
Owner

This helps ensure that plot performance doesn't plummet as samples accumulate. You can't currently leave the GUI running because of this

@vkottler vkottler added the enhancement New feature or request label Nov 16, 2023
@vkottler vkottler self-assigned this Nov 16, 2023
@vkottler
Copy link
Owner Author

Maybe 10-20s as a start is good? Actually, since we're running the UI at a fixed frequency (which is sampling the state of the underlying program), maybe a sample depth (based on the UI rate) makes sense.

Err... even if the human interface to set the threshold is in seconds, under the hood we can compute sample depth.

@vkottler
Copy link
Owner Author

I think a good "default" behavior should be to set a sane cap on the number of max samples at any given time (a stateful member of the TUI task), maybe like 1024?

That way the plot "grows" until it becomes saturated with samples

this should be configurable via the config file, too

@vkottler
Copy link
Owner Author

Implemented here: #45.

About 64 points max on the plot looks pretty good with a full-screen app open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant