Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Great library, a few ideas #1

Open
aasaru opened this issue May 27, 2021 · 2 comments
Open

Great library, a few ideas #1

aasaru opened this issue May 27, 2021 · 2 comments

Comments

@aasaru
Copy link

aasaru commented May 27, 2021

Hi!

Great work!

A few ideas for improvement.

  • have as few dependencies as possible (get rid of Lombok - I'm maintaining a library that does not have Lombok and if I would add a dependency on your library it would mean my library has to depend on Lombok)
  • also consider adding support other countries like Lithuania (they have same id-code system as Estonia) and Latvia (beware that newer Latvian id-codes don't have birthdate in them)
  • make separate classes for parsing idCode, generating idCode and validating idCode - just for clarity and to separate use cases.

Cheers!
Juhan

@vladislavgoltjajev
Copy link
Owner

Hi, thank you very much for the feedback.
Haven't touched this in a while, didn't even know Bintray was dead.
Might pick it up again in the future, but probably under a different name if I were to include other countries.

@vladislavgoltjajev
Copy link
Owner

Made a new library - https://github.com/vladislavgoltjajev/java-personal-code.
Will delete this repo soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants