-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NgSemantic is not a module #149
Comments
Seems like a similar issue to #144. |
Works for me with this on package.json : @vladotesanovic : I read somewhere on angular-cli issue, that lib must be compiled with angular > 2.2.* because of an incompatibility. |
Failing for me with these dependencies:
|
Failing for me as well:
|
Ok, so after A LOT of wrestling, i've finally managed to solve my issues. First, those are my dependencies:
The most important things are:
One last obvious thing...please rm -rf node modules folder and do a clean install of all the modules |
Today I started new project, still getting NGSemanticModule is not an NgModule. |
@ReFiRnE try to use the same dependencies that i've used. In particular, update angular, ts-node and zone.js |
Thanks @gnegno84! That worked :) |
This issue appear when you use angular-cli (i'm using angular-cli version 1.0.0-beta.26) because is based in webpack, and the library was created for systemjs, i'm working to port it. Currently this branch works https://github.com/BennyFranco/ngSemantic/tree/angular-cli but I need to do some debug tasks and create a way to maintain the compatibility with both. |
I just fixed one line in
Even works with Angular 2.4.6. |
@borisfeldmann are you working with angular-cli? |
Hi @BennyFranco, yes I am using I could fix it by adding this to the file
|
Thanks @borisfeldmann! That worked for me!! |
…or "NgSemanticModule is not an NgModule"
@borisfeldmann thanks, that worked! |
@borisfeldmann Great Fix! Will this be available with the fix on NPM anytime soon? The github shows the code in place, but when installing via npm; the code is not there.
|
Still not working when doing a fresh |
The only working solution is @borisfeldmann's and because of |
This Comment works perfectly for me thanks to @gnegno84. Just Pay attention to I still wonder why there's no latest release on NPM? 🤔 |
for me, using the version 1.0.0 of @angular/cli and its dependencies, the working solution was to add the NgModule annotation on ng.semantic.d.ts file
|
above solution works for me with typescript 2.2.1 and angular cli 1.0.1 |
Boris solution works... hopefully @vladotesanovic will update the NPM package as this does not seem such a big change |
@vladotesanovic, @borisfeldmann I have forked the project and proposed a fix on #178, that would update this library to angular-cli and fix this issue. Hope that it serves. |
hey everyone, I too have been struggling with the NgSemanticModule is not a module issue and I just recently upgraded to Angular 4. Same as above, when angular first compiles, it gives me that error, but when I change some code, it recompiles without the error. I see some of you have found a fix by changing the Does anyone have any suggestions? I see there a pull request to fix this from @mp3sii but I'm actually not entirely sure what to do with that. Can I merge that change into my project as well? @mp3sii would I be able to merge your changes into mine? Has anyone else gotten this to work with Angular 4? UPDATE: So I finally figured out how to implement @borisfeldmann 's fix. I had to find the file in Verified working on |
borisfeldmann fix didn't work for me - I already had those lines in my ng-semantic.d.ts file. Also, tried npm install. Line in my app.module.ts And my dependencies:
|
@borisfeldmann your solution works for me, even on "ngx-semantic-ui" package with "typescript@2.3.4 |
I had an error (ngSemantic with angular error - unexpected module NgSemanticModule) using ng build --prod and it was fixed using in ng.semantic.d.ts file: |
Im still having this issue. although implementing @borisfeldmann solution fixes it for me, is there a pending pull request to fix the issue or any plan to implement it? |
Commenting out |
…or "NgSemanticModule is not an NgModule"
When using any angularcli@>1.0.0-beta.21. It does not recognize NgSemantic as a valid module.. it works for me with angularcli@1.0.0-beta.21
The text was updated successfully, but these errors were encountered: