Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup should use event.currentTarget #163

Open
flemeur opened this issue Feb 28, 2017 · 2 comments
Open

Popup should use event.currentTarget #163

flemeur opened this issue Feb 28, 2017 · 2 comments

Comments

@flemeur
Copy link

flemeur commented Feb 28, 2017

I'm experiencing an issue using the popup component. If I have a button with an icon inside and click on the icon the popup will use the icon as element for the popup instead of the button itself. This can be avoided by using event.currentTarget (https://github.com/vladotesanovic/ngSemantic/blob/master/src/popup/popup.ts#L31) which always points to the element the handler is attached to (the button), instead of the element that created the event (the button or the icon)

See: https://developer.mozilla.org/en-US/docs/Web/API/Event/currentTarget

@Ralla
Copy link

Ralla commented Mar 1, 2017

I would love to see a fix for this.

@marsdk
Copy link

marsdk commented Mar 2, 2017

+1 on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants