Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Compiler] Support all event types #108

Open
wwerner opened this issue Dec 12, 2019 · 2 comments
Open

[Compiler] Support all event types #108

wwerner opened this issue Dec 12, 2019 · 2 comments
Labels
P:2 Mid Priority

Comments

@wwerner
Copy link
Contributor

wwerner commented Dec 12, 2019

Currently, all types are generated as subclasses of DomainEvent.
Other types need to be declared and used in io.vlingo.schemata.codegen.backend.java.JavaBackend#baseClassOf
@VaughnVernon
Copy link
Contributor

VaughnVernon commented Dec 12, 2019 •
edited
Loading

@wwerner For now I would prefer to have standard base classes only for Command and DomainEvent. I have tried to think of good reasons for standards for the other types, such as Data, Document, and Envelope, but I can't.

See: #98 (comment)

@wwerner wwerner added the P:2 Mid Priority label Feb 2, 2020
@hurelhuyag
Copy link
Contributor

This issue should be fixed by #180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P:2 Mid Priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wwerner @hurelhuyag @VaughnVernon