Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

applying a different --git* combination to workload should replace rather than merge existing git settings #427

Closed
heyjcollins opened this issue Dec 1, 2022 · 2 comments

Comments

@heyjcollins
Copy link
Contributor

WIP

Description of problem

current behavior merges --git values.
in the case where the original workload was created with --git-commit
if the user subsequently wants to update the workload using --git-tag or git-branch the workload will not be updated because on the backend fluxCD will give precedence to the commit and ignore the tag/branch.
this could be confusing for the user

Proposed solution

<Please describe your proposed solution, preferably in the following style:>

Given <Some Condition>
When <Something Happens>
Then <This other thing should happen?>

Example

<Code snippets that illustrate the when/then blocks>

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

@heyjcollins
Copy link
Contributor Author

Not sure we should implement this because all other flag behavior is executed as a merge rather than replace.
Also - would we ONLY do this for --git-comit, --git-tag, --git-branch - and not require the --git-repo?

The behavior is likely to be confusing.

@heyjcollins
Copy link
Contributor Author

going to close this. We can create a new issue if/when we receive feedback indicating an update the current UX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant