Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL displayed in workload get output doesn't depend directly on any given runtime #47

Open
heyjcollins opened this issue Mar 28, 2022 · 1 comment
Labels

Comments

@heyjcollins
Copy link
Contributor

Description of problem

Currently, the apps plugin gets the URL for a given workload directly from the knative service.
This implementation is brittle (if/when a workload has been deployed to a runtime other than kn, even if a publicly addressable route has been configured, there will be no URL displayed in workload get output).

Proposed solution

Given my workload is running, but not as a knative service and the workload has been configured to respond to public http requests (has an addressable URL)
When I run `tanzu apps workload get` for the workload
Then the publicly addressable URL is included in the command output

Example

<Code snippets that illustrate the when/then blocks>

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

@heyjcollins heyjcollins added enhancement New feature or request needs-triage labels Mar 28, 2022
@atmandhol atmandhol added this to the 0.7.0 milestone Mar 31, 2022
@atmandhol atmandhol removed this from the 0.7.0 milestone Apr 18, 2022
@heyjcollins
Copy link
Contributor Author

Not migrated because this will not be addressed in carto v1 and it's not clear how this will be addressed in v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants