Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footgun with relative paths and workdir option #1

Open
vorner opened this issue Sep 2, 2018 · 1 comment
Open

Footgun with relative paths and workdir option #1

vorner opened this issue Sep 2, 2018 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@vorner
Copy link
Owner

vorner commented Sep 2, 2018

The first time configuration is loaded, it is before switching the working directory (because the config contains the directory to switch to). The next time it is after the switch. If there's a relative path, it may point to something else or not exist, logging errors and not updating the config.

Possible improvements:

  • Turn all the paths we know about to absolute on startup.
  • Try loading the configuration once more just after switching the directory. This way errors manifest sooner (optimally even before we go to background), so the user is aware of them.
@vorner vorner added the help wanted Extra attention is needed label Sep 2, 2018
@vorner
Copy link
Owner Author

vorner commented Oct 19, 2018

Turning all the ones from command line is done in v0.2.4. The ones from configuration wouldn't work ‒ the configuration may be reloaded later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant