-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CodeMirror integration for vova07 Yii2 Redactor widget #169
Open
NickGoodwind
wants to merge
20
commits into
vova07:master
Choose a base branch
from
NickGoodwind:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codemirror integration
Redactor modification to allow the correct integration with CodeMirror
Final CodeMirror integration
Nickg update to assets
Structure update to remove unnecessary parent folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodeMirror integration for Yii2 Redactor widget
In this fork from the original vova07 Imperavi widget for Yii2, we created a new implementation to allow the correct integration with the CodeMirror API. In this fork, two files were changed, including the original
redactor.js
v10 and the Widget class. Also, a newCodemirroAsset
asset bundle file was created to internally manage thecodemirror
assets for the Yii application. Finally, the CodeMirror assets were included inside theassets
folder.Here are the main changes:
Widget
CodemirrorAsset
Redactor.js - Creation of a new method to implement the CodeMirror editor instant inside the
Redactor.build
function and modification of theRedactor.build.run
function