Merge pull request #135 from bastelfreak/strict

CI: Build gems with strictness and verbosity & Add upper version limits to gemspec
voxpupuli · Sep 15, 2023 · b89f021 · b89f021
2 parents 670f0a9 + cb7eab4
commit b89f021
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -18,7 +18,7 @@ jobs:
         env:
           BUNDLE_WITHOUT: release
       - name: Build gem
-        run: gem build *.gemspec
+        run: gem build --strict --verbose *.gemspec
       - name: Publish gem to rubygems.org
         run: gem push *.gem
         env:

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -48,7 +48,7 @@ jobs:
       - name: spec tests
         run: bundle exec rake test
       - name: Verify gem builds
-        run: gem build *.gemspec
+        run: gem build --strict --verbose *.gemspec
 
   tests:
     needs:

diff --git a/metadata-json-lint.gemspec b/metadata-json-lint.gemspec
@@ -16,13 +16,12 @@ Gem::Specification.new do |s|
   s.required_ruby_version = '>= 2.5.0'
 
   s.add_runtime_dependency 'json-schema', '>= 2.8', '< 5.0'
-  s.add_runtime_dependency 'semantic_puppet'
+  s.add_runtime_dependency 'semantic_puppet', '~> 1.0'
   s.add_runtime_dependency 'spdx-licenses', '~> 1.0'
-  s.add_development_dependency 'rake'
-  s.add_development_dependency 'rspec'
+  s.add_development_dependency 'rake', '~> 13.0', '>= 13.0.6'
+  s.add_development_dependency 'rspec', '~> 3.12'
   s.add_development_dependency 'rubocop', '~> 1.28.0'
   s.add_development_dependency 'rubocop-performance', '~> 1.10'
   s.add_development_dependency 'rubocop-rake', '~> 0.2'
-  s.add_development_dependency 'rubocop-rspec', '>= 1.44'
-
+  s.add_development_dependency 'rubocop-rspec', '~> 2.10.0'
 end