Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add .yardopts to prevent yard/puppet strings to create .yardoc folder #72

Closed
wants to merge 1 commit into from

Conversation

rwaffen
Copy link
Member

@rwaffen rwaffen commented Sep 2, 2024

No description provided.

…folder

Signed-off-by: Robert Waffen <rwaffen@gmail.com>
@rwaffen rwaffen enabled auto-merge September 2, 2024 13:16
@rwaffen rwaffen requested a review from bastelfreak September 2, 2024 13:16
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this better? AFAIK we already have .yardoc in .gitignore and adding this file means we always ship an additional file. My aim was always to ship as little boiler plate as possible and this feels like a step back. Is there a benefit to this?

@rwaffen
Copy link
Member Author

rwaffen commented Sep 3, 2024

this is more like a fix for a test. i have a gitlab runner which runs as a unpriviledged user, but can start containers as root, which run internally as root. so i end up having root files in my runner git checkout which the runner cannot clean up anymore.

so i thought if i prevent the generation of the .yardoc folder at all, i'm done and this test sample can continue.

i also have another cleanup workaround in the test, if this is not the way we wanna go here.

@rwaffen
Copy link
Member Author

rwaffen commented Sep 19, 2024

do not need this anymore, closing

@rwaffen rwaffen closed this Sep 19, 2024
auto-merge was automatically disabled September 19, 2024 15:01

Pull request was closed

@rwaffen rwaffen deleted the add_yardopts branch September 19, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants