Relative path used as file resource in mcollective::user

[RayYHan]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: 4.9.0
• Ruby: 2.0.0p648
• Distribution:
• Module version:

How to reproduce (e.g Puppet code you use)

Using the mco_profile::client class in the ssl_example provided with default parameters

What are you seeing

Relative path error

What behaviour did you expect instead

Output log

Error: Failed to apply catalog: Parameter source failed on File[/root/.mcollective.d/credentials/certs/ca.pem]: Cannot use relative URLs '' at /etc/puppetlabs/code/environments/production/modules/mcollective/manifests/user.pp:79

Any additional information you'd like to impart

According to the documentation for the file type, the source attribute is supposed to be a URI instead of a path. Weirdly, the mco_profile::middleware::activemq class works fine with relative path as file resource. But the exact same path will not work in mcollective::user.

[jameseck]

This is due to the mco_profile::client class not inheriting mco_profile::params.

The class definition should read like the below:

class mco_profile::client (
$middleware_hosts = $mco_profile::params::middleware_hosts,
$ssl_server_cert = $mco_profile::params::ssl_server_cert,
$ssl_server_private = $mco_profile::params::ssl_server_private,
$ssl_server_public = $mco_profile::params::ssl_server_public,
$ssl_ca_cert = $mco_profile::params::ssl_ca_cert,
$connector = $mco_profile::params::connector,
) inherits mco_profile::params {