-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplement the modal component #1101
Comments
May I suggest following the same road as the |
I don't like the idea of experimental, I think it's better to create the tests for the current modal and it works on a specific branch for the modal refactor without breaking the tests... And then when you have everything correctly (without breaking anything) then it starts incrementally add the new features that are desired. |
Another change I want to suggest is to |
@emersonlaurentino What happens if we want to add breaking changes to the modal? 🤔 |
Since there are already tests, you make your PR for the branch of The advantage of the experimental ones is that you can generate beta versions at any time. |
Overview
Implement our own modal component with the same functionalities but without using external components.
Purpose
Currently, Styleguide Modal uses an external component which is not very well maintained and doesn't attend to all our requirements, such as:
After we reimplement, we could work on new features such as these ones.
The text was updated successfully, but these errors were encountered: