Feature/add size prop #1251
Merged
Feature/add size prop #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edenalsant
requested review from
analuizamtg,
thayannevls,
emersonlaurentino,
estacioneto,
ThiagoAugustoSM,
lariciamota,
ullayne02 and
a team
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/styleguide-core/styleguide/jrdn7ulds |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 11ef5ac:
|
ullayne02
reviewed
Jun 17, 2020
edenalsant
force-pushed
the
feature/add-size-prop
branch
from
72e3c7b
to
93ac131
Compare
analuizamtg
reviewed
Jun 17, 2020
estacioneto
reviewed
Jun 18, 2020
thayannevls
reviewed
Jun 18, 2020
thayannevls
reviewed
Jun 18, 2020
thayannevls
reviewed
Jun 18, 2020
thayannevls
reviewed
Jun 18, 2020
edenalsant
force-pushed
the
feature/add-size-prop
branch
from
e084989
to
136a24a
Compare
emersonlaurentino
approved these changes
Jun 25, 2020
matheusps
force-pushed
the
feature/add-size-prop
branch
from
954ad96
to
1d259f8
Compare
edenalsant
force-pushed
the
feature/add-size-prop
branch
from
1d259f8
to
e809252
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Add display prop to make AutocompleteInput size be determined by its value
What problem is this solving?
issue 1244
The static definition of the AutocompleteInput component's size
How should this be manually tested?
Clone this repo and run
yarn && yarn styleguidego to
localhost:6060Screenshots or example usage
In the file
react/components/AutcompleteInput/README.mdyou can set the propdisplayto either value ofsmall,regular,largeor you can simply ignore this prop (default is set toregular).You should see the bar changing according to the specified size
small - regular - large (respectively)
Types of changes