Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

false negative of vue/no-mutating-props when mutating destructured prop #2548

Open
2 tasks done
n0099 opened this issue Sep 6, 2024 · 0 comments
Open
2 tasks done

Comments

@n0099
Copy link

n0099 commented Sep 6, 2024

Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have read the FAQ and my problem is not listed.

Tell us about your environment

  • ESLint version: 9.9.1
  • eslint-plugin-vue version: 9.28.0
  • Vue version: 3.5.1
  • Node version: 22.8.0
  • Operating System: Windows 11

Please show your full configuration:
https://github.com/n0099/open-tbm/blob/fec399a0c9e462c77aaf5e6d5a081529428d8597/fe/eslint.config.js

What did you do?
https://github.com/n0099/open-tbm/blob/fec399a0c9e462c77aaf5e6d5a081529428d8597/fe/src/components/post/queryForm/QueryForm.vue#L241

What did you expect to happen?
Reporting as the default value of option shallowOnly for this rule is false.

What actually happened?
Not reporting unless referencing from the original props.queryFormDeps

-        uniqueParams.value.postTypes.value = from; // to prevent empty post types
+        props.queryFormDeps.uniqueParams.value.postTypes.value = from; // to prevent empty post types

Repository to reproduce this issue
https://github.com/n0099/open-tbm/blob/fec399a0c9e462c77aaf5e6d5a081529428d8597/fe

@n0099 n0099 changed the title false negative of vue/no-mutating-props when mutating deconstructed prop false negative of vue/no-mutating-props when mutating destructed prop Sep 6, 2024
@FloEdelmann FloEdelmann changed the title false negative of vue/no-mutating-props when mutating destructed prop false negative of vue/no-mutating-props when mutating destructured prop Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants