Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vue/no-bare-strings-in-template: per-component ignoring of slot content #2613

Open
justingrant opened this issue Nov 18, 2024 · 0 comments
Open

Comments

@justingrant
Copy link

justingrant commented Nov 18, 2024

The v-icon component in Vuetify for Vue 2 uses the default slot to define the icon ID. This is not user-readable text, so I'd like to disable vue/no-bare-strings-in-template for all contents of any <v-icon> components.

For Vue3, this has been moved from a slot to an icon prop, so it's a non-issue there. But ignoring slot contents for some components seems like a good addition to this rule.

What rule do you want to change?
vue/no-bare-strings-in-template

Does this change cause the rule to produce more or fewer warnings?

Fewer

How will the change be implemented? (New option, new default behavior, etc.)?

New option to allow some components or tags to be exempted (by name). For example:

  'vue/no-bare-strings-in-template': ['error',
    {
      ignoreSlots: {
        'v-icon': [ true /* true means default slot */, 'some-other-slot-name' ]
      }
    }
  ]

Please provide some example code that this change will affect:

          <v-icon color="error">
            $power
          </v-icon>

What does the rule currently do for this code?
Error, because the rule thinks that $power should be localized.

What will the rule do after it's changed?
No error.

Additional context

@justingrant justingrant changed the title vue/no-bare-strings-in-template: per-component exclusions vue/no-bare-strings-in-template: per-component ignoring of slot content Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant