fix[test] integration tests #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielSchiavini
force-pushed
the
fix/integration-tests
branch
from
745cf77 to
18ab5b6
Compare
boa/contracts/base_evm_contract.py
Outdated
| @@ -45,6 +45,12 @@ class StackTrace(list): | |||
| def __str__(self): | |||
| return "\n\n".join(str(x) for x in self) | |||
|
|
|||
| @property | |||
| def dev_reason(self) -> str | None: | |||
| if isinstance(self.last_frame, str): | |||
There was a problem hiding this comment.
oof, when can this happen?
There was a problem hiding this comment.
a few lines later:
boa/contracts/base_evm_contract.py
Outdated
| @@ -76,9 +82,9 @@ def _handle_child_trace(computation, env, return_trace): | |||
| else: | |||
| child_trace = child_obj.stack_trace(child) | |||
|
|
|||
| if child_trace.last_frame.dev_reason and not return_trace.last_frame.dev_reason: | |||
| if child_trace.dev_reason and not return_trace.dev_reason: | |||
There was a problem hiding this comment.
this change looks spooky. maybe we should check if last_frame is not None?
There was a problem hiding this comment.
we should still test for is not None, as you could have an empty dev reason (which is valid)
There was a problem hiding this comment.
the return value of dev_reason could still be an empty string!
charles-cooper
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #202
Tested in https://github.com/DanielSchiavini/titanoboa/actions/runs/9029296510/job/24811369660?pr=7 via DanielSchiavini#7
Cute Animal Picture