Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Reminder Time Formatted Incorrectly in exported note inside a notebook #86

Open
dgreen opened this issue Apr 12, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@dgreen
Copy link

dgreen commented Apr 12, 2024

evernote-backup version

1.9.3

What OS are you using?

MacOS

OS Version / Linux distribution

Sonoma 14.4.1

Bug description

Yarle reports that the reminder time is in the wrong format.

evernote-backup's notebook XML of a note shows

  <reminder-time>1719842400000</reminder-time>

where an ENEX export of the same notebook shows the note's reminder as

  <reminder-time>20240701T140000Z</reminder-time>

10.84.3-mac-ddl-public (20240409145102)
Editor: v177.16.3
Service: v1.100.4
© 2019 - 2024 Evernote Corporation. All rights reserved

Log excerpt

No response

@dgreen dgreen added the bug Something isn't working label Apr 12, 2024
@dgreen
Copy link
Author

dgreen commented Oct 17, 2024

It looks like the problem is in note_formatter.py that has (starting in line 34 of the source I looked at):

        if note.attributes:
            note_skeleton["note"]["note-attributes"] = {
                "subject-date": fmt_time(note.attributes.subjectDate),
                "latitude": note.attributes.latitude,
                "longitude": note.attributes.longitude,
                "altitude": note.attributes.altitude,
                "author": note.attributes.author,
                "source": note.attributes.source,
                "source-url": note.attributes.sourceURL,
                "source-application": note.attributes.sourceApplication,
                "reminder-order": note.attributes.reminderOrder,
                "reminder-time": note.attributes.reminderTime,
                "reminder-done-time": note.attributes.reminderDoneTime,
                "place-name": note.attributes.placeName,
                "content-class": note.attributes.contentClass,
            }

I think the lines with reminder-time and reminder-done-time should have the value converted with fmt_time()

                "reminder-time": fmt_time(note.attributes.reminderTime),
                "reminder-done-time": fmt_time(note.attributes.reminderDoneTime),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant