Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use colon separator or kebab-case for method-specific DID parameter names? #35

Closed
brentzundel opened this issue Sep 23, 2019 · 6 comments
Assignees
Labels
discuss Needs further discussion before a pull request can be created pending close Issue will be closed shortly if no objections

Comments

@brentzundel
Copy link
Member

@peacekeeper moved from CCG (w3c-ccg/did-spec#199)

@msporny msporny added the discuss Needs further discussion before a pull request can be created label Oct 1, 2019
@OR13
Copy link
Contributor

OR13 commented Feb 18, 2020

I assumed this was colon based.... most of the examples I have seen use colons...

Blocked by matrix parameter decision.... (link to blocking issue) (my opinion always...)

@talltree
Copy link
Contributor

@OR13 is correct—this is currently waiting on a decision about #159.

@kdenhartog
Copy link
Member

Isn't initial-value kebab-case @OR13? I've not seen anything other than kebab-case now that I'm thinking about it. Can you link me to one?

@OR13
Copy link
Contributor

OR13 commented Mar 11, 2020

https://www.w3.org/TR/did-core/#method-specific-parameters

https://www.w3.org/TR/did-core/#method-specific-did-url-parameters

https://www.w3.org/TR/did-core/#example-4

did:example:21tDAKCERh95uGgKbJNHYp;service=agent;foo:bar=high

I assumed method specific parameters was regarding the last example ^

it would be ion:initial-state, elem:initial-state, etc...

@peacekeeper
Copy link
Contributor

peacekeeper commented Mar 12, 2020

This issue was about whether to use a : or a - to separate the method name from the parameter name, in which case you couldn't use the - anymore in parameter names themselves.

So you'd have something like ion-initialstate instead of ion:initial-state.

Since we already have parameter names that use -, and since the : is already the familiar character for separating a method name, I don't think this issue makes much sense anymore.

I'll close unless @talltree or someone else objects.

@peacekeeper peacekeeper added the pending close Issue will be closed shortly if no objections label Mar 12, 2020
@brentzundel
Copy link
Member Author

No activity since marked pending close, closing.

peacekeeper added a commit to peacekeeper/did-core that referenced this issue Mar 31, 2020
msporny pushed a commit that referenced this issue May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Needs further discussion before a pull request can be created pending close Issue will be closed shortly if no objections
Projects
None yet
Development

No branches or pull requests

6 participants