Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec defines 'double' in a way that collides with WebIDL #89

Closed
hober opened this issue Jan 24, 2024 · 3 comments · Fixed by #91
Closed

Spec defines 'double' in a way that collides with WebIDL #89

hober opened this issue Jan 24, 2024 · 3 comments · Fixed by #91

Comments

@hober
Copy link
Member

hober commented Jan 24, 2024

Maybe use a different term?

I'm seeing this Bikeshed error on an unrelated document:

LINK ERROR: Multiple possible 'double' idl refs.
Arbitrarily chose https://w3c.github.io/edit-context/#dom-underlinestyle-double
To auto-select one of the following refs, insert one of these lines into a <pre class=link-defaults> block:
spec:edit-context; type:enum-value; text:double
spec:webidl; type:interface; text:double
{{double}}
@dandclark
Copy link
Contributor

@snianu or @alexkeng do you know where "double" would actually be needed? In Chromium at least it doesn't look like "double" is a possible IME underline style (link):

  enum class UnderlineStyle {
    kNone,
    kSolid,
    kDot,
    kDash,
    kSquiggle,
  };

I'm wondering if this can just be removed...but maybe you remember some context for why it's an option in the spec? Is it used with IMEs in other browsers?

@dandclark
Copy link
Contributor

I spoke with @snianu about this today. double was added to EditContext early on because it was expected to be used by a planned Windows feature, but that feature never landed. So at least for now there is no known use for it. I will Agenda+ to discuss next WG meeting but I expect that this can simply be removed.

@css-meeting-bot
Copy link
Member

The Web Editing Working Group just discussed Spec defines 'double' in a way that collides with WebIDL #89.

The full IRC log of that discussion <dandclark> topic: Spec defines 'double' in a way that collides with WebIDL #89
<dandclark> github: https://github.com//issues/89
<smaug> dandclark: double isn't actually hooked up with anything, so there is no known use for it
<smaug> dandclark: if it is not used, we should just remove it
<smaug> johanneswilm: is use cases appear in the future, we can add more types
<smaug> johanneswilm: anyone fine removing it
<smaug> yes
<smaug> https://github.com//issues/88
<smaug> topic https://github.com//issues/88
<smaug> dandclark: the spec doesn't handle the bounds of the selection start/end
<smaug> dandclark: should we clamp or throw ?
<smaug> smaug: Range does throw
<smaug> johanneswilm: throwing error could make it easier to find issues in js code
<smaug> johanneswilm: it would be good to give a way to find js issues
<smaug> smaug: are there APIs which do clamp?
<smaug> dandclark: maybe the right answer is to throw
<smaug> dandclark: hopefully we can find that no one relies on the current behavior
<smaug> dandclark: and also if we can find counter example where clamping does happen
<smaug> smaug: by default we should try to follow existing old APIs
<smaug> dandclark: I'll investigate

dandclark added a commit that referenced this issue Feb 14, 2024
The `double` UnderlineStyle was added in anticipation of a planned Windows feature that never came to be. There are no other known uses, so remove it.

Closes #89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants