Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken since docker 26 #534

Open
sbp-bvanb opened this issue Jun 13, 2024 · 13 comments
Open

Broken since docker 26 #534

sbp-bvanb opened this issue Jun 13, 2024 · 13 comments
Labels
bug Something isn't working

Comments

@sbp-bvanb
Copy link

What happened:

Github ubuntu 20.04 updated the docker version from 24 to 26

What you expected to happen:

dive continued to work

How to reproduce it (as minimally and precisely as possible):

Run dive with docker 26

Anything else we need to know?:

Environment:

  • OS version
  • Docker version (if applicable)
@black-snow
Copy link

black-snow commented Jun 18, 2024

Fetching image... (this can take a while for large images)
cannot fetch image
could not find 'blobs/sha256/whatever' in parsed layers

For me this seems to be related to containerd storage engine. I think it broke as I switched to it.

@alastair87
Copy link

I agree re. containerd storage engine. I had containerd enabled on Docker Desktop with Docker v26.1.4 on Windows 11 with WSL2 - it was broken with containerd enabled but disabling containerd fixed it. It would be helpful if it was compatible with containerd though.

@calebAtIspot
Copy link

Anyone know how to download and run a earlier docker version on mac? Brew only has the latest version. I tried downloading from https://download.docker.com/mac/static/stable/aarch64/but got "“docker” can’t be opened because Apple cannot check it for malicious software. when I tried running it.

@calebAtIspot
Copy link

ah found the install instructions: https://docs.docker.com/engine/install/binaries/

In my case running xattr -rc docker fixed the error I was getting

@max-allan
Copy link

Disabling containerd in Docker Desktop settings on OSX has fixed it for me. (With latest version of Docker Desktop : Docker version 27.0.2, build 912c1ddf8a)
But it would be ideal to be compatible with containerd too.

@froody
Copy link

froody commented Aug 12, 2024

The issue is the heuristic here is broken because newer oci layers do gzip small layers, so they are skipped because they don't fill the buffer. Commenting out that check means I can load gcr.io/distroless/nodejs20-debian12:latest which I couldn't before.

@froody
Copy link

froody commented Aug 20, 2024

I hacked around it, pushed my changes here: https://github.com/froody/dive/tree/crane

quite a significant change, basically uses crane as a dest for docker to "push" to, much faster downloads, and now we have the manifest/config ahead of time to decide on the file format

@reneleonhardt
Copy link

I hacked around it, pushed my changes here: https://github.com/froody/dive/tree/crane

quite a significant change, basically uses crane as a dest for docker to "push" to, much faster downloads, and now we have the manifest/config ahead of time to decide on the file format

Wow, thank you for your work! Can you make a PR?

@froody
Copy link

froody commented Aug 23, 2024

@reneleonhardt ok I'll try

@reneleonhardt
Copy link

Thank you, let me know if I can help 🙂

@bredamatt
Copy link

Disabling containerd does it on OSX (Docker Desktop).

@DeanAyalon
Copy link

DeanAyalon commented Oct 10, 2024

(workaround - irrelevant, see next comment)

Disabling containerd does it on OSX (Docker Desktop).

Instead of disabling it, you can use Docker-in-Docker:

docker run -d --name dind --privileged docker
sleep 2
docker exec -it dind \
    docker run --rm -it \
    -v /var/run/docker.sock:/var/run/docker.sock \
    wagoodman/dive [image/command]    # or jauderho/dive for ARM64

While not a solution at tool-level, this does provide a workaround without abandoning the privileges of using the containerd store


You can also use deanayalon/dive-dind instead, which is a simple 'docker' docker image with the dive binary installed (Source)

docker run -d --privileged --name dive-dind deanayalon/dive-dind
sleep 2
docker exec -it dive-dind dive [image/command]

The repository also offers a convenient shell script to manage the entire thing, including quick and simple transfer of local images into the dive-dind container

There's also the deanayalon/dive-dind:jauderho tag for their fork


This was created as I could not get froody's binary working

@DeanAyalon
Copy link

DeanAyalon commented Nov 2, 2024

Could not get froody's binary working
Issue seems to be resolved with #511 thanks to maddog2050 (source)

joschi added a commit to joschi/dive that referenced this issue Nov 6, 2024
Fixes wagoodman#507
Fixes wagoodman#510
Fixes wagoodman#526
Fixes wagoodman#534

Co-authored-by: Maddog2050 <17902029+Maddog2050@users.noreply.github.com>
joschi added a commit to joschi/dive that referenced this issue Nov 7, 2024
Fixes wagoodman#507
Fixes wagoodman#510
Fixes wagoodman#526
Fixes wagoodman#534

Co-authored-by: Maddog2050 <17902029+Maddog2050@users.noreply.github.com>
joschi added a commit to joschi/dive that referenced this issue Nov 7, 2024
Fixes wagoodman#507
Fixes wagoodman#510
Fixes wagoodman#526
Fixes wagoodman#534

Co-authored-by: Maddog2050 <17902029+Maddog2050@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

9 participants