Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make light-js example a proper debugging tool #248

Open
Ivansete-status opened this issue Jul 7, 2023 · 9 comments
Open

feat: make light-js example a proper debugging tool #248

Ivansete-status opened this issue Jul 7, 2023 · 9 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Ivansete-status
Copy link

Summary

Provide a "combobox" component that allows easily select the target node in https://examples.waku.org/light-js/

Details

The https://examples.waku.org/light-js/ is great indeed! and I use it very often. However, I think it would be great to make it easier to switch among the different known nwaku nodes.

I suggest having a "combobox/dropdown list" component where the user can easily pick up one of the major nwaku nodes.

For example, there could be the next values: test-ams; test-us; test-hk; prod-ams; prod-us; prod-hk.

I usually get the underlying multiaddress string from the information given by https://fleets.status.im/ although this is not the best source of this information.

Quotes:

@jm-clius: I don't think we should build anything on fleets.status.im - this is simply a handy "cheat list" of nodes, but is not meant to be maintained or be used in any features.
@fryorcraken: Maybe the right way is to pull all nodes from DNS discovery to build the drop list

@Ivansete-status Ivansete-status added enhancement New feature or request good first issue Good for newcomers labels Jul 7, 2023
@fryorcraken fryorcraken transferred this issue from waku-org/js-waku Jul 10, 2023
@weboko weboko moved this to Triage in Waku Jul 10, 2023
@weboko
Copy link
Contributor

weboko commented Jul 10, 2023

Here I added the easiest solution for now that just takes the first discovered peer and puts it into the input.
#250

This solution should be improved and drop-down can be made out of it.

Additionally, I think light-js can be reworked a bit: some CSS styles added and the readability of the code improved.

@fryorcraken
Copy link
Collaborator

I would rebrand light-js into a debugging tool and redirect developers on other example which have an "app" usage.

@danisharora099
Copy link
Contributor

rename to debug-lightpush-waku?

(open to suggestions :P)

@danisharora099 danisharora099 moved this from Triage to To Do in Waku Aug 3, 2023
@fryorcraken
Copy link
Collaborator

rename to debug-lightpush-waku?

(open to suggestions :P)

just debug-waku at this point in time as we don't recommend/document the usage of relay.

@danisharora099
Copy link
Contributor

danisharora099 commented Aug 7, 2023

thinking again: debug-waku sounds like a name of a draft PR to investigate a temp bug.
waku-debugger perhaps?

@fryorcraken
Copy link
Collaborator

event better debugger as we would be in Waku context.

@weboko
Copy link
Contributor

weboko commented Oct 28, 2023

then we should extend the example to keep up with the name:

  • add usage of Store;
  • add usage of Relay (questionable); - not implementing
  • show list of peers;
  • expose variables to window.* so that accessible from console;
  • add info in the console about ability to run expressions there;
  • add list of peers to dial;
  • add input for multiaddr to dial particular peer;

@adklempner
Copy link
Member

I will be taking this on

@weboko weboko changed the title Add dropdown list in https://examples.waku.org/light-js/ feat: make light-js example a proper debugging tool Oct 30, 2023
@weboko weboko moved this from To Do to In Progress in Waku Oct 30, 2023
@adklempner
Copy link
Member

Weekly Update

  • achieved: added peer dropdown, list of connected peers, and button for querying past messages using store
  • next: will take on my first issue in js-waku

@adklempner adklempner moved this from In Progress to Done in Waku Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Archived in project
Development

No branches or pull requests

5 participants