Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: HealthManager should provide an events-based API #2198

Open
danisharora099 opened this issue Dec 16, 2024 · 1 comment
Open

feat: HealthManager should provide an events-based API #2198

danisharora099 opened this issue Dec 16, 2024 · 1 comment
Assignees

Comments

@danisharora099
Copy link
Collaborator

Problem

HealthManager's role is to aggregate and provide data around individual protocols' health status (number of peers connected for a protocol) in the form of async methods: getProtocolHealth()/getOverallHealth().

On consumer-side, these methods allow access to information, but live updates are not available. Workaround has been to call these methods in intervals of time. This creates a delay and adds friction to promptly be able to respond to the node's state of connections.

Solution

Provide an events-based API for changes to the protocols' health statuses

cc @vpavlin

@chair28980 chair28980 added this to Waku Dec 16, 2024
@danisharora099 danisharora099 self-assigned this Dec 16, 2024
@weboko weboko moved this to Triage in Waku Dec 16, 2024
@weboko
Copy link
Collaborator

weboko commented Dec 18, 2024

Let's build a simple API around ConnectionManager and expose amount of peers per protocol.
Event based API can be build on top of libp2p events similarly to connection state on ConnectionManager.

@weboko weboko moved this from Triage to In Progress in Waku Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

2 participants