-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kotlinx.serialization
error message exposed in /wallet-api/auth/login
#72
Comments
This issue has been marked as stale. |
The github bot marked this issue as "stale", but I keep my point. I'm afraid this kind of error should be treated before being thrown to the end user.
It's and internal My suggestion is to treat it the same way other fields validations are made, like this: It's also related to this other issue: |
This issue has been marked as stale. |
should be fixed with this PR : #591 |
Version tested: v1.0.2401181053-SNAPSHOT
If the
type
field is omitted or misspelled, the returning error message is an internalkotlinx.serialization
exception.Wouldn't it be better to encapsulate it in a more readable, domain-specific message, as is the case with the handling of the
email
andpassword
fields?Error handling of
type
field with a difficult-to-debug messageRequest
Response
Error handling of the
email
field, although imperfect, is more readable than the previous caseRequest
Response
The text was updated successfully, but these errors were encountered: