Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formatter not running when hitting Crtl+Shift+S or save all #32

Open
gocarlos opened this issue Feb 23, 2018 · 1 comment
Open

formatter not running when hitting Crtl+Shift+S or save all #32

gocarlos opened this issue Feb 23, 2018 · 1 comment

Comments

@gocarlos
Copy link

First of all thanks for the great extension.

To the issue:
I've seen that with Eclipse Oxygen.1a the clang-formatter does not run after save if saving via "Save all".

By hitting Crtl + S or "Save" the file is formatted and saved as expected.

I think that the normal behavior would be to also format all files that are not saved when saving via "save all"

@jmcarter17
Copy link

Hi, we have the same issue. We would like to see that "save all" or ctrl+shift+s (save all) formats the files also, if we have chosen to "Run clang-format on file save".

Also, if we have checked "Save automatically before build" in our workspace settings, it doesn't format on those saves either.

I believe all 3 cases (save-all button, ctrl-shift-s and save before build) are the same problem, but they should all, in my opinion, format the files. They are all "save all" operations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants