Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dangerous check for __func__ #3181

Open
jacereda opened this issue Jul 5, 2024 · 0 comments
Open

Dangerous check for __func__ #3181

jacereda opened this issue Jul 5, 2024 · 0 comments

Comments

@jacereda
Copy link

jacereda commented Jul 5, 2024

Hi,

This will potentially break code including the header:

://github.com/warmcat/libwebsockets/blob/8674bf1585c0196f071eb6f0ae2184c9ca053301/include/libwebsockets.h#L146

__func__ is not a preprocessor macro, so this test will redefine the builtin mechanism potentially breaking macros that use func in the ways c99 allows.

It should probably check if we're on >=C99.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant