Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used fixed versions of ubuntu runners on GH Workflows #578

Closed
AlexRuiz7 opened this issue Dec 5, 2024 · 2 comments · Fixed by #608 or wazuh/wazuh-indexer-reporting#14
Closed

Used fixed versions of ubuntu runners on GH Workflows #578

AlexRuiz7 opened this issue Dec 5, 2024 · 2 comments · Fixed by #608 or wazuh/wazuh-indexer-reporting#14
Assignees
Labels
level/task Task issue request/operational Operational requests type/maintenance Maintenance issue

Comments

@AlexRuiz7
Copy link
Member

AlexRuiz7 commented Dec 5, 2024

Description

The workflows are reporting a warning about ubuntu-latest being moved to ubunut-24.04 soon. Some of the steps already use this version of the Ubuntu runner. For consistency, and in order to avoid failures in the future, change every ubuntu-latest runners to ubuntu-24.04.

image

Caution

Moreover, we should ensure that we do not use the "latest" version of any GH Action for any workflow used by us on any of our 3 repositories.

@AlexRuiz7 AlexRuiz7 added level/task Task issue type/maintenance Maintenance issue request/operational Operational requests labels Dec 5, 2024
@wazuhci wazuhci moved this to Backlog in Release 5.0.0 Dec 5, 2024
@f-galland
Copy link
Member

It seems all of the occurrences of ubuntu-latest can be found within the workflows:

fede@tyner:~/src/wazuh-indexer (master)
$ grep -R 'ubuntu-latest'
.github/workflows/dco.yml:    runs-on: ubuntu-latest
.github/workflows/lucene-snapshots.yml:    runs-on: ubuntu-latest
.github/workflows/changelog_verifier.yml:    runs-on: ubuntu-latest
.github/workflows/version_check.yml:    runs-on: ubuntu-latest
.github/workflows/delete_backport_branch.yml:    runs-on: ubuntu-latest
.github/workflows/assemble.yml:        os: [ubuntu-latest, windows-latest, macos-13]
.github/workflows/precommit.yml:        os: [ubuntu-latest, windows-latest, macos-latest, macos-13]
.github/workflows/build.yml:    runs-on: ubuntu-latest
.github/workflows/build.yml:    runs-on: ubuntu-latest
.github/workflows/poc-checklist.yml:    runs-on: ubuntu-latest
.github/workflows/wrapper.yml:    runs-on: ubuntu-latest
.github/workflows/version.yml:    runs-on: ubuntu-latest
.github/workflows/backport.yml:    runs-on: ubuntu-latest
.github/workflows/create-documentation-issue.yml:    runs-on: ubuntu-latest
.github/workflows/gradle-check.yml:    runs-on: ubuntu-latest
.github/workflows/gradle-check.yml:    runs-on: ubuntu-latest
.github/workflows/gradle-check.yml:    runs-on: ubuntu-latest
.github/workflows/copy-linked-issue-labels.yml:    runs-on: ubuntu-latest
.github/workflows/codeql.yml:    runs-on: ${{ (matrix.language == 'swift' && 'macos-latest') || 'ubuntu-latest' }}
.github/workflows/links.yml:    runs-on: ubuntu-latest
.github/workflows/publish-maven-snapshots.yml:    runs-on: ubuntu-latest
.github/workflows/dependabot_pr.yml:    runs-on: ubuntu-latest
.github/workflows/auto-release.yml:    runs-on: ubuntu-latest
.github/workflows/detect-breaking-change.yml:    runs-on: ubuntu-latest

@wazuhci wazuhci moved this from Backlog to Pending review in Release 5.0.0 Dec 19, 2024
@wazuhci wazuhci moved this from Pending review to Backlog in Release 5.0.0 Dec 19, 2024
@wazuhci wazuhci moved this from Backlog to In progress in Release 5.0.0 Dec 19, 2024
@f-galland
Copy link
Member

No wazuh-indexer-plugins workflow seems to be using ubuntu-latest at the moment:

fede@tyner:~/IdeaProjects/wazuh-indexer-plugins (master)
$ grep -Rl ubuntu-latest

@wazuhci wazuhci moved this from In progress to Pending review in Release 5.0.0 Dec 19, 2024
@wazuhci wazuhci moved this from Pending review to Done in Release 5.0.0 Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level/task Task issue request/operational Operational requests type/maintenance Maintenance issue
Projects
Status: Done
2 participants