Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to frontend-maven-plugin #29

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Switch to frontend-maven-plugin #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ maven-eclipse.xml
infinitest.filters

node_modules/
node/
npm-debug.log

.nodejs
Expand Down
13 changes: 0 additions & 13 deletions .maven-settings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,19 +42,6 @@
</snapshots>
</repository>

<repository>
<id>maven-nodejs-proxy</id>
<url>https://maven-nodejs-proxy.pvtool.org</url>
<layout>default</layout>
<releases>
<enabled>true</enabled>
<updatePolicy>never</updatePolicy>
</releases>
<snapshots>
<enabled>false</enabled>
</snapshots>
</repository>

<repository>
<id>oss-snapshots</id>
<url>https://oss.sonatype.org/content/repositories/snapshots</url>
Expand Down
2 changes: 1 addition & 1 deletion bundle/.nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v16.15.0
v20.11.1
3 changes: 0 additions & 3 deletions bundle/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,5 @@
"grunt-eslint": "24.0.0",
"grunt-html2js": "0.8.0",
"load-grunt-tasks": "5.1.0"
},
"engines": {
"node": "16.15.0"
}
}
51 changes: 31 additions & 20 deletions bundle/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,30 +209,41 @@

<!-- Nodejs Maven Plugin to run the templates compilation and tests -->
<plugin>
<groupId>io.wcm.maven.plugins</groupId>
<artifactId>nodejs-maven-plugin</artifactId>
<groupId>com.github.eirslett</groupId>
<artifactId>frontend-maven-plugin</artifactId>
<executions>
<execution>
<phase>generate-sources</phase>
<goals><goal>run</goal></goals>
<id>install node and npm</id>
<goals>
<goal>install-node-and-npm</goal>
</goals>
<phase>process-resources</phase>
<configuration>
<nodeVersion>v20.11.1</nodeVersion>
<npmVersion>10.2.4</npmVersion>
stefanseifert marked this conversation as resolved.
Show resolved Hide resolved
</configuration>
</execution>
<execution>
<id>npm install</id>
<goals>
<goal>npm</goal>
</goals>
<phase>process-resources</phase>
<configuration>
<arguments>install</arguments>
</configuration>
</execution>
<execution>
<id>grunt build</id>
<goals>
<goal>grunt</goal>
</goals>
<phase>process-resources</phase>
<configuration>
<arguments>build</arguments>
</configuration>
</execution>
</executions>
<configuration>
<nodeJsVersion>16.15.0</nodeJsVersion>
<tasks>
<npmInstallTask>
<workingDirectory>${project.basedir}</workingDirectory>
</npmInstallTask>
<nodeJsTask>
<workingDirectory>${project.basedir}</workingDirectory>
<moduleName>grunt-cli</moduleName>
<executableName>grunt</executableName>
<arguments>
<argument>build</argument>
</arguments>
</nodeJsTask>
</tasks>
</configuration>
</plugin>

<plugin>
Expand Down