Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update computation of accuracy so it's consistent with best practices #417

Open
paulalbert1 opened this issue Jul 24, 2020 · 2 comments
Open

Update computation of accuracy so it's consistent with best practices #417

paulalbert1 opened this issue Jul 24, 2020 · 2 comments
Assignees
@paulalbert1

Comments

@paulalbert1
Copy link
Contributor

Right now, accuracy is calculated as the average of precision and recall.

We should change it to: (true positive + true negative) / (true positive + true negative + false positive + false negative)
@paulalbert1 paulalbert1 self-assigned this Jul 24, 2020
paulalbert1 added a commit that referenced this issue Jul 24, 2020
@paulalbert1
Recompute overall accuracy
19dadab 
As per #417
@paulalbert1
Copy link
Contributor Author

Here's the proposed code for the change. This didn't work, but hopefully it gives you the idea.
19dadab#diff-787324bc47fdd0a159b58f738bf98665

@paulalbert1 paulalbert1 mentioned this issue Apr 4, 2023
Merged
@paulalbert1
Copy link
Contributor Author

paulalbert1 commented Apr 4, 2023 •
edited
Loading

This PR should cover it. We need to test to make sure this works as intended.
#512

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulalbert1 paulalbert1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paulalbert1