Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equality checking when navigating back #90

Open
torresmi opened this issue Jul 2, 2018 · 2 comments
Open

Equality checking when navigating back #90

torresmi opened this issue Jul 2, 2018 · 2 comments

Comments

@torresmi
Copy link

torresmi commented Jul 2, 2018

In the methods Navigator.goBackTo and Navigator.goBackBefore there are checks on the screen argument using structural equality (.equals()). The rest of the implementation uses referential equality.

Is it intentional to only allow for equal references in these methods? I have paths that are structurally equal but different references, so they won't work with these functions.

@ryanmoelter
Copy link
Contributor

Thanks for reporting!

I'll have to put a little more thought into which version of equality we use, but regardless, we should be consistent across the library.

I'm guessing you would prefer structural equality everywhere?

@torresmi
Copy link
Author

Sounds good! Consistency would be nice.

My preference would be structural equality so users don't have to manage references everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants