Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Big Fan of Your Continued Excellence #616

Open
tshedor opened this issue Aug 24, 2024 · 6 comments
Open

A Big Fan of Your Continued Excellence #616

tshedor opened this issue Aug 24, 2024 · 6 comments

Comments

@tshedor
Copy link
Contributor

tshedor commented Aug 24, 2024

Recently I had to update an app. And not just the app - it was everything you never want to upgrade. Every muscle in my body contracted in anticipation of BREAKING CHANGE CHANGELOG.md notes. I awaited a stack failure on bundle exec rails s. This would be no small upgrade.

The ruby version was in the high 2s. Who knows what dragons await on the major side of that number. My heart was pounding twice per keystroke. Three point one dot six. There was certain calamity to come in the far reaches of Gemfile.lock. In a cold sweat, I typed gem 'rails'..........'~> 7.0.2'. Two major versions. This was foolish. I questioned my life's choices.

Yet none of this mattered if Fae wasn't ready. A delete keystroke swiped. Gone was the version lock. Fae could install whatever version it wanted. Oh dear. I yelled to my secretary to clear the calendar. "The whole afternoon?" "The entire week!" The rest of my life was destined for endless StackOverflow /opt/var/usr/local/homebrew/log.log queries.

$ bundle.

Green ASCII colors? It couldn't be. It was. The clouds parted. In tepid glee, the terminal accepted $ bundle exec rails s and started! On port 3000! Beautiful port 3000! Blessed day. Blessed weekend. Blessed maintainers that made my path clear.

A decade later, you're still making this work on Rails and major Ruby upgrades. To those who continue to maintain and update Fae, I salute you. @jasonfine @jamesmk

@jasonfine
Copy link
Member

@tshedor great to hear from you, hope you've been well! Curious about more details here - what was your process to do the upgrade? Did you upgrade to Fae 3?

Delete the lock file -> set the Fae version in the Gemfile -> bundle install -> that's it?

@tshedor
Copy link
Contributor Author

tshedor commented Aug 27, 2024

@jasonfine If we're being scientific, the process hewed closer to this:

  1. Realize Heroku was forcing an upgrade from Ruby 2.7.4
  2. rbenv install 3.1.6; rbenv local 3.1.6
  3. Update .ruby-version
  4. Change to ruby '3.1.6' in Gemfile
  5. Remove version constraints on fae-rails and rails.
  6. bundle
  7. Too many failures; clear Gemfile.lock and rerun bundle (fae-rails installed as 3.0.0)
  8. Can't install pg gem, yada yada yada, now I can install pg
  9. bundle succeeds
  10. rails s fails. There's some stack issue that's starting with Rails.application.initialize! and going into Rails internals.
  11. Review dummy and see what version y'all have
  12. Pin rails to ~> 7.0.2 in Gemfile
  13. Profit

Ok so maybe I romanticized the experience

@jasonfine
Copy link
Member

Thanks for the update @tshedor, glad to hear the process didn't drive you to over consumption of KC Teas :)

@tshedor
Copy link
Contributor Author

tshedor commented Aug 28, 2024

@jasonfine I return to you with another hiccup. I got this error please use symbols for polymorphic route arguments and resolved it by replacing all occurrences of simple_form_for(['admin', with simple_form_for([:admin,

@tshedor
Copy link
Contributor Author

tshedor commented Aug 28, 2024

Also wow KC Teas, what a shout

@tshedor
Copy link
Contributor Author

tshedor commented Aug 30, 2024

@jasonfine Hey it's me again. Hit another "didn't see that coming." The env/*.rb files seem to be loaded before the application.rb file, which is a reverse of what happened in earlier Rails (?) versions. I had some mucus in application.rb that was dev code that override an env/production.rb setting. live, laugh, learn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants