feat: add quick-start demo #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboreham
reviewed
Aug 3, 2021
There was a problem hiding this comment.
Thanks for this! I think it would be improved with a little more explanation.
- kspan will run with the powers of
cluster-admin. While this simplifies the config it might not be allowed for some people. I think the instructions should at least note this. - maybe some instructions on what users should do next - how do they get the UI up in a browser for instance?
| @@ -43,6 +43,11 @@ To run Jaeger locally: | |||
| docker run -d --name jaeger -p 16686:16686 -p 55680:55680 jaegertracing/opentelemetry-all-in-one | |||
| ``` | |||
|
|
|||
| To run Jaeger on kubernetes | |||
There was a problem hiding this comment.
It will run both Kspan and Jaeger, right?
|
@Belyenochi do you think you will come back to this? |
|
@bboreham If this pr is no longer active, I'd love to help. Could I create a new pr to give a doc for deploy a demo on kind? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Instructions to run kspan. [Issue link]: #4