Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rspress HMR is broken after enabling new tree shaking #5270

Closed
chenjiahan opened this issue Jan 8, 2024 · 6 comments · Fixed by #5053
Closed

Rspress HMR is broken after enabling new tree shaking #5270

chenjiahan opened this issue Jan 8, 2024 · 6 comments · Fixed by #5053
Assignees
Labels
bug Something isn't working rsbuild rsbuild related

Comments

@chenjiahan
Copy link
Member

chenjiahan commented Jan 8, 2024

System Info

@rspack/core 0.5.0 canary (0.4.5-canary-be59383-20240105051840)

System:
OS: macOS 14.0
CPU: (10) arm64 Apple M1 Pro
Memory: 49.02 MB / 16.00 GB
Shell: 5.9 - /bin/zsh
Binaries:
Node: 18.12.1 - ~/Library/Caches/fnm_multishells/22567_1704199739974/bin/node
npm: 8.19.2 - ~/Library/Caches/fnm_multishells/22567_1704199739974/bin/npm
pnpm: 8.14.0 - ~/Library/Caches/fnm_multishells/22567_1704199739974/bin/pnpm
bun: 0.1.2 - ~/.bun/bin/bun
Browsers:
Chrome: 120.0.6099.199
Safari: 17.0

Details

Rspress HMR is broken after enabling new tree shaking:

image

Reproduce link

https://github.com/web-infra-dev/rsbuild/tree/new_tree_shaking_0108

Reproduce Steps

  1. git clone git@github.com:web-infra-dev/rsbuild.git --branch new_tree_shaking_0108
  2. pnpm i
  3. cd packages/document
  4. pnpm dev
  5. open http://localhost:8080/guide/basic/json-files in browser
  6. open packages/document/docs/en/guide/basic/json-files.md in editor, type something.
@chenjiahan chenjiahan added bug Something isn't working pending triage The issue/PR is currently untouched. labels Jan 8, 2024
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Jan 8, 2024
@chenjiahan chenjiahan added rsbuild rsbuild related and removed team The issue/pr is created by the member of Rspack. labels Jan 8, 2024
@IWANABETHATGUY
Copy link
Contributor

try this
0.4.5-canary-058c885-20240108162457

@chenjiahan
Copy link
Member Author

@IWANABETHATGUY I can still reproduce this issue in @rspack/core v0.5.1...

image

branch: https://github.com/web-infra-dev/rsbuild/tree/new_tree_shaking_01172

@chenjiahan chenjiahan reopened this Jan 17, 2024
@jerrykingxyz jerrykingxyz self-assigned this Jan 17, 2024
@h-a-n-a h-a-n-a removed the pending triage The issue/PR is currently untouched. label Jan 25, 2024
@chenjiahan
Copy link
Member Author

chenjiahan commented Feb 6, 2024

With Rspack v0.5.3, Panic occurred after updating packages/document/docs/en/guide/basic/json-files.md.

branch: https://github.com/web-infra-dev/rsbuild/tree/new_tree_shaking_01172

image

@chenjiahan chenjiahan reopened this Feb 6, 2024
@IWANABETHATGUY
Copy link
Contributor

@jerrykingxyz can you have a look?

@IWANABETHATGUY
Copy link
Contributor

Can you try the latest 0.5.6?

@chenjiahan
Copy link
Member Author

Fixed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rsbuild rsbuild related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants