Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: The panic location includes the Rspack CI path #6192

Closed
chenjiahan opened this issue Apr 10, 2024 · 5 comments
Closed

[Bug]: The panic location includes the Rspack CI path #6192

chenjiahan opened this issue Apr 10, 2024 · 5 comments
Labels
bug Something isn't working team The issue/pr is created by the member of Rspack.

Comments

@chenjiahan
Copy link
Member

System Info

Rspack v0.6.0

System:
OS: macOS 14.4.1
CPU: (10) arm64 Apple M1 Pro
Memory: 197.97 MB / 16.00 GB
Shell: 5.9 - /bin/zsh
Binaries:
Node: 18.12.1 - ~/Library/Caches/fnm_multishells/99377_1712756954621/bin/node
Yarn: 1.22.19 - ~/Library/Caches/fnm_multishells/99377_1712756954621/bin/yarn
npm: 8.19.2 - ~/Library/Caches/fnm_multishells/99377_1712756954621/bin/npm
pnpm: 7.17.1 - ~/Library/Caches/fnm_multishells/99377_1712756954621/bin/pnpm
bun: 0.1.2 - ~/.bun/bin/bun
Browsers:
Chrome: 123.0.6312.107
Safari: 17.4.1

Details

The panic location includes the Rspack CI path, is this expected?

image

Reproduce link

https://github.com/colinaaa/rsbuild-vitest-crash-repro

Reproduce Steps

  1. pnpm i
  2. pnpm vitest
@chenjiahan chenjiahan added bug Something isn't working pending triage The issue/PR is currently untouched. labels Apr 10, 2024
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 10, 2024
@xc2
Copy link
Collaborator

xc2 commented Apr 15, 2024

please run vitest under forks mode instead of threads mode via

import { defineProject } from 'vitest/config'

export default defineProject({
  test: {
     pool: 'forks'
  }
});

running rspack in worker_threads has not been well tested yet.

@xc2 xc2 added pending triage The issue/PR is currently untouched. and removed pending triage The issue/PR is currently untouched. labels Apr 15, 2024
@xc2
Copy link
Collaborator

xc2 commented Apr 16, 2024

sry never realized that this issue was related to the location path (/ω\)

@chenjiahan
Copy link
Member Author

Haha never mind~

@h-a-n-a
Copy link
Contributor

h-a-n-a commented Apr 26, 2024

The returned name refers to a source path on the compiling system and the panic handler we've been using does not support mapping the location file. This can be achieved mapping the print_panic_info of color-backtrace result and handle the panic by yourself.

@h-a-n-a h-a-n-a removed the pending triage The issue/PR is currently untouched. label Apr 26, 2024
@chenjiahan
Copy link
Member Author

Get it 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

No branches or pull requests

3 participants