Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: webpackChunkName not used if name contains period #6358

Closed
JohnDaly opened this issue Apr 24, 2024 · 0 comments · Fixed by #6411
Closed

[Bug]: webpackChunkName not used if name contains period #6358

JohnDaly opened this issue Apr 24, 2024 · 0 comments · Fixed by #6411
Labels
bug Something isn't working

Comments

@JohnDaly
Copy link

System Info

rspack v0.6.3

Details

The magic comment in this example will be respected by Webpack, but not by rspack

import(/* webpackChunkName: "component.Mod" */ './mod');

See linked repro for full example

Reproduce link

https://github.com/JohnDaly/rspack-magic-comment-repro

Reproduce Steps

  1. npm run dev
  2. npm run build
  3. Notice that the assets generated by Webpack use the webpackChunkName. The assets generated by rspack do not
@JohnDaly JohnDaly added bug Something isn't working pending triage The issue/PR is currently untouched. labels Apr 24, 2024
@xc2 xc2 mentioned this issue Apr 29, 2024
Merged
2 tasks
xc2 added a commit to xc2/rspack that referenced this issue Apr 29, 2024
@xc2
test: issue web-infra-dev#6358
0275972
@xc2 xc2 removed the pending triage The issue/PR is currently untouched. label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: allow all characters for webpackChunkName xc2/rspack
2 participants
@JohnDaly @xc2