-
-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Global polyfill no longer seems to work #6984
Comments
Hello @isuro, sorry we can't investigate the problem further without reproduction demo, please provide a repro demo by forking rspack-repro, or provide a minimal GitHub repository by yourself. Issues labeled by |
tried to reproduce with no luck, would you please help creating a repo with reproductable setup. |
I think the specific issue may have been code like this: const g = global
g.foo = BAR
... |
Since the issue was labeled with |
System Info
System:
OS: Linux 6.9 Ubuntu 20.04.6 LTS (Focal Fossa)
CPU: (8) arm64 unknown
Memory: 4.82 GB / 23.43 GB
Container: Yes
Shell: 5.8 - /usr/bin/zsh
Binaries:
Node: 20.11.0 - ~/.nvm/versions/node/v20.11.0/bin/node
Yarn: 4.1.0 - ~/.nvm/versions/node/v20.11.0/bin/yarn
npm: 10.2.4 - ~/.nvm/versions/node/v20.11.0/bin/npm
Browsers:
Chromium: 115.0.5790.75
npmPackages:
@rspack/core: ^0.7.5 => 0.7.5
@rspack/dev-server: ^0.7.5 => 0.7.5
Details
After upgrading from rspack 0.7.0 to 0.7.5, global is no longer polyfilled for browser environments. This is true when left at the default behavior or when explicitly passing
node: {global: true}
.Reproduce link
No response
Reproduce Steps
In our case, the specific line that fails is
const g: any = global;
The text was updated successfully, but these errors were encountered: