-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notify people of export PRs that bypass review #65
Comments
@annevk I think you've asked about this as well, do you remember where the previous discussion happened? |
This can really help with planning - as it allows us (i.e., Mozilla's DOM Team) to start thinking about how to fix stuff and get things prioritized when updated tests fail. It also helps catch little things, like things that are |
@foolip the discussion previously might just have been on IRC; I certainly would like to know everything touching |
@foolip web-platform-tests/wpt#8434 is somewhat related. (If the distinction could be made, I'd be interested in seeing changes to existing tests, but not so much in the addition of new tests or tentative tests. That's where I've mainly seen errors introduced at least, which is what I care about the most.) |
This is technically straightforward to detect, but to notify or not depending on it would require per-user settings. I guess those could live in the META.yml files, is that what you'd like? |
Sounds great! |
In web-platform-tests/wpt#15306 @marcoscaceres asked about being notified of changes to payment-request/. Currently, @wpt-pr-bot will approve export PRs:
wpt-pr-bot/lib/comment.js
Lines 24 to 27 in 7b89f1a
Review on the PR itself wouldn't be meaningful, and sometimes PRs are created for changes that never land even in the upstream repository, so if people are notified doing so after the PR has been merged is probably best.
Notifying in a comment would be OK because no other humans are looking at these PRs. But it has to be simple to filter out these notifications.
The text was updated successfully, but these errors were encountered: