-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"wpt manifest" should be able to update manifest for directories of interest only #47350
Comments
Also we'd like to have a way to skip MtimeCache, or preferably remove that altogether. (MtimeCache would only be useful for running tests locally, but with the proposal above it should not be needed anymore.) |
@jgraham @gsnedders What would be your opinion on this? |
Note that this isn't totally trivial to get right, for example if you pass in What's the concern with the mtime cache? Performance or correctness? Since gecko is still using Mercurial, and has some workflows that don't use VCS checkouts at all, having some caching layer that doesn't depend on the source being in a git repo continues to be important to us. |
My plan is to pass in a path relative to the
I think this is fine.
I thought it is too complex and unnecessary to keep all kinds of caches in this process. But we can keep it if it is still used at gecko side. |
When run WPTs locally, we (at least at google) always update the WPT Manifest to make sure the test is run correctly (e.g. to make sure Wptrunner view the the test type correctly). Updating WPT manifest is slow at this point because "wpt manifest" does not allow a partial update. On Linux it takes about 4 seconds to update WPT manifest, and would be even slower on Windows.
Suggestions is to allow "wpt manifest" to update for the file or directories of interest. For example, the command "git ls-tree -r -z HEAD" takes about 1.5 seconds on Linux, yet "git ls-tree -r -z HEAD badging/badge-success.https.html" takes about 0.01 seconds. There would be other savings also, and we believe the total time for this can be made to be < 0.1 second for running a single test, which is the usual case.
WPT Manifest holds information about "test type", references for reftests, so updating infor for the test file will be good enough.
The text was updated successfully, but these errors were encountered: