Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari stable runs missing since September 13th #48223

Open
DanielRyanSmith opened this issue Sep 17, 2024 · 12 comments
Open

Safari stable runs missing since September 13th #48223

DanielRyanSmith opened this issue Sep 17, 2024 · 12 comments

Comments

@DanielRyanSmith
Copy link
Contributor

The last run for Safari stable was the 12th.

https://wpt.fyi/runs?label=master&label=stable&max-count=100&product=chrome&product=firefox&product=safari

Looking at the invalid runs tab here, I'm seeing some invalid Safari runs on the 16th.

CC @gsnedders

@gsnedders
Copy link
Member

Retrying the last few runs (i.e., all the daily runs since the 12th) on the 16th failed because it was then rerunning them with the now-released Safari 18.0, thus the invalid runs.

I've hit re-run on the first Azure Pipelines run where everything is running against Safari 18.0 (i.e., from today).

We also got https://github.com/web-platform-tests/wpt/actions/runs/10894890454 yesterday, but it failed to upload results.

@past
Copy link
Member

past commented Sep 17, 2024

web-platform-tests/wpt.fyi#4003 should fix the missing runs from GitHub Actions at least. Daniel, can you schedule another deployment this week?

@DanielRyanSmith
Copy link
Contributor Author

A new version of wpt.fyi has been deployed today. 👍

@gsnedders
Copy link
Member

@DanielRyanSmith @past Re-running the notify job is still failing in the same way: https://github.com/web-platform-tests/wpt/actions/runs/10925326720/job/30347359745

Not sure if either of you have any insights here?

@DanielRyanSmith
Copy link
Contributor Author

I haven't had a chance to look at this in-depth, but that correlates to the logic here.

@gsnedders
Copy link
Member

@DanielRyanSmith Sure, but I don't see how we've ended up there at all. Like, we should be on a route that shouldn't ever end up there, far as I can tell?

@past
Copy link
Member

past commented Sep 20, 2024

Looking at the code with the help of a debugger shows that the /api/checks/github-actions route isn't handled by the new handler, but goes through the same handler as the /api/checks/{commit} route.

@DanielRyanSmith
Copy link
Contributor Author

I don't know if anything else has changed, but I can see that we have some newly ingested aligned runs.

@gsnedders
Copy link
Member

This is just prodding the Azure Pipelines runs to re-run; nothing is actually solved.

We should maybe spin out the wpt.fyi problems onto an issue on that repo?

@past
Copy link
Member

past commented Sep 20, 2024

Filed web-platform-tests/wpt.fyi#4009

@past
Copy link
Member

past commented Sep 25, 2024

The fix for the missing runs from GitHub Actions was just deployed. We should hopefully see some runs later today.

@gsnedders
Copy link
Member

So https://github.com/web-platform-tests/wpt/actions/runs/11039052681/job/30670828741 succeeded (which implies that the results receiver got through the uploader and all without giving any error), got 200 back, https://wpt.fyi/status doesn't list any pending github-actions submissions, https://wpt.fyi/runs?max-count=100&from=2024-09-18T00%3A00&product=safari%5Bgithub-actions%5D doesn't have any runs either. There's a bunch of logging, but I don't know where that ends up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants