Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for neos 8 #1

Open
paavo opened this issue May 11, 2023 · 6 comments
Open

support for neos 8 #1

paavo opened this issue May 11, 2023 · 6 comments

Comments

@paavo
Copy link

paavo commented May 11, 2023

No description provided.

@sbruggmann
Copy link
Contributor

@paavo did you already test or do you have a pr more or less ready?

@paavo
Copy link
Author

paavo commented May 12, 2023

I forked the repository and updated the neos dependencies to Neos 8.x.
I installed the package and created a Redirect like this:

Screenshot 2023-05-12 at 09 45 25

/yolo redirects to / instead of the localized node /de/firma or /company (EN Default)

/yolo returns a 307 Redirect with the Location node://cc877081-499f-4b46-8967-a6abc65ce679
So it looks like, the node:// Link doesn't get parsed @sbruggmann

Am i missing something? 🤔

@sbruggmann
Copy link
Contributor

On my side it worked now.
@paavo Can you please check again with dev-master as dependencies and make sure to flush cache after installing the package.
Otherwise maybe the Aspect is not loaded and "node://" is not replaced.

@paavo
Copy link
Author

paavo commented May 15, 2023

Thanks for your hints @sbruggmann
I tried to debug:

In DEV-Environment (Neos Dev-Websever) i get a a Location: node://<node-identifier>
In "Local Productive" Environment i get http://devhost.local//localization-redirect/<node-identifier> which throws a 404.

What is {node} from routing:list {node}/localization-redirect/{identifier}? 🤔

@sbruggmann
Copy link
Contributor

@paavo Okay you've probably found an issue which does exist since the beginning.

Do you have a default Dimension with empty uriSegment?
In this case I can reproduce your described behaviour.

Without uriSegment I don't get a node to build the redirect target and currently I don't see a fix.

@paavo
Copy link
Author

paavo commented May 20, 2023

Do you have a default Dimension with empty uriSegment?

Yes @sbruggmann
We always use an empty URI-Segment for the default Dimension to prevent duplicated content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants