Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gulp and post-css integrating #6

Open
Ensaphelon opened this issue May 16, 2017 · 1 comment
Open

gulp and post-css integrating #6

Ensaphelon opened this issue May 16, 2017 · 1 comment

Comments

@Ensaphelon
Copy link
Contributor

Ensaphelon commented May 16, 2017

Hello @mmenozzi , what do you think about using an NPM to install a bootstrap (I'm talking about the latest, further alpha releases) and including it to our .less file? I think it would be good to write a simple gulp-configuration for the implementation of post-css plug-ins and other things. In this case, you'll have to add the compiled css-file to the source folder of bootstrap theme, so that the magento simply copies it to the pub/static directory, because the server software will not be able to process the syntax of the post-css plug-ins.

@mmenozzi
Copy link
Member

Hi @Ensaphelon. I'm not very expert about NPM and Gulp and I'm not sure to understand your proposal.

Anyway keep in mind that this theme has been designed to be a base/blank theme that should be used as the parent theme of the one used inside a specific project. So it's important to have the less files in the web/css folder because, in this way, in the project's theme you can override only the bootstrap-theme.less and _variables.less files to completely customize the look and feel of your store. Is the same concept provided by Magento with the Magento UI library (http://devdocs.magento.com/guides/v2.1/frontend-dev-guide/css-topics/theme-ui-lib.html).

If your proposal is compatible with this philosophy it's ok for me, feel free to submit a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants