Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document webpack change: Fix layer is missing in dynamic import with dynamic resource #6876

Open
webpack-bot opened this issue Jun 5, 2023 · 2 comments
Assignees

Comments

@webpack-bot
Copy link

A pull request by @huozhi was merged and maintainers requested a documentation change.

See pull request: webpack/webpack#17310


Summary

When you're using dynamic import with dynamic resource name with feature layers enabled, the dynamic imported files didn't inherit with the parent layer

related issue on next.js side: vercel/next.js#49382

🤖 Generated by Copilot at 8422d51

This pull request adds support for layers in ContextModule and tests the feature with different scenarios of dynamic imports and resources. It also adds a new rule to the webpack configuration file for assigning modules to layers based on their names.

Details

🤖 Generated by Copilot at 8422d51

  • Add layer property to ContextModule class and its serialization and deserialization methods (link, link, link)
  • Set layer property of data object in ContextModuleFactory class from contextInfo object populated by ContextDependency class (link)
  • Add new rule to webpack configuration file to assign dynamic-layer layer to files matching dynamic-module-layer in name (test/configCases/layer/rules/webpack.config.js, link)
  • Add new test case file dynamic-module-layer.js to export an object with name, layer, and modules properties, where modules is an array of promises resolving to dynamic modules imported with dynamic resources (test/configCases/layer/rules/dynamic-module-layer.js, link)
  • Add new test case files module1.js and module2.js to export objects with name and layer properties, where layer is a special variable __webpack_layer__ replaced by webpack at runtime (test/configCases/layer/rules/dynamic/module1.js, link; test/configCases/layer/rules/dynamic/module2.js, link)
  • Import object from dynamic-module-layer.js and add new test case to assert that layer property of object and dynamic modules match dynamic-layer (test/configCases/layer/rules/index.js, link, link)
@alexander-akait
Copy link
Member

Ref: #6750

@cannarron
Copy link

Hello, Is this open for external help?

@snitin315 snitin315 self-assigned this Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants