Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding clases/messages #18

Open
agcoesbenr opened this issue Jan 11, 2022 · 2 comments
Open

Adding clases/messages #18

agcoesbenr opened this issue Jan 11, 2022 · 2 comments

Comments

@agcoesbenr
Copy link
Contributor

Hi,
I'm just curious.
I'm finding my self adding messagetypes that already exists under the Tools-folder. What is not clear to me is:

  1. What does the sync-messages script do and how to use it?
  2. If i.e. the diagnostic message types are already made (in the Tools) folder, how come they are not just a part of the library? They are a part of the ROS protocol. If it's from space-reasons, classes are almost no impact and it would provide a much more sufficient library.
@wesgood
Copy link
Owner

wesgood commented Jan 13, 2022

Hello,
it looks like the sync-messages tool compares the ROS repo messages with the app itself. Unfortunately I don't think it's been finished completely and likely doesn't provide any useful action yet.

Building messages in the RBSManager format is time consuming so I was only able to generate a handful of messages most applicable to my project. Some users have contributed messages that are required for their project so I'm happy to include those in a PR.

I'm currently investigating how to build v2.0 and I think as part of that I will be removing the ObjectMapper requirement to stick with more iOS specific components. That means the mapping process will again be different -- using the Codable protocol -- so maybe at that time I will look at including far more messages.

@agcoesbenr
Copy link
Contributor Author

Awesome.

I have implemented the diagnostics messages and will PR them soon.

Sounds good with exchanging ObjectMapper for Codable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants