Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exposure of dm field in item documents #16

Open
hategan opened this issue Sep 17, 2018 · 0 comments
Open

Fix exposure of dm field in item documents #16

hategan opened this issue Sep 17, 2018 · 0 comments

Comments

@hategan
Copy link
Collaborator

hategan commented Sep 17, 2018

Before #15 tests were failing because /dm/session/:id1/item/:id2 was moved to /dm/fs/item/:id. Both endpoints were supposed to return item dictionaries with the 'dm' field included. I believe that the former worked based on the understanding that tests were passing at some time. @Xarthisius reports that /dm/fs/item/:id did not expose the 'dm' field in items and opted for adding the 'dm' field to the list of exposed fields for the normal item API, while switching the tests to simply use /item/:id.

The fact that /dm/session/:id1/item/:id2 was only called from the tests means that exposing the 'dm' field in all instances makes it useless in most instances. This issue is here to remind us that we might opt for a different solution in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant