Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong order for target variable names in Paper_Figures.ipynb #2

Open
amullen01 opened this issue Jun 28, 2023 · 1 comment
Open

Wrong order for target variable names in Paper_Figures.ipynb #2

amullen01 opened this issue Jun 28, 2023 · 1 comment
Assignees

Comments

@amullen01
Copy link
Collaborator

amullen01 commented Jun 28, 2023

paper_figures_a

To my understanding the naming convention for target variables is {variable}{compartment}{pft} e.g. VEGC00 = leaf VEGC for PFT0, VEGC22 = root VEGC for PFT2.

For SA, the outputs for target variables (output.txt) are ordered by PFT first, then compartment.
example: VEGC00, VEGC10, VEGC20, VEGC10, VEGC11, VEGC12

In Paper_Figures.ipynb and it looks like some of the other plotting scripts, the output.txt file is being read and columns are being set ordered by compartment then PFT, whereas it should be the other way around.

I don't think this is affecting results, just the plot x labels.

If someone could double check this to confirm, I can make an adjustment in Paper_Figures.ipynb when I push my results.

@aiza-k
Copy link
Collaborator

aiza-k commented Jun 29, 2023

I checked this, and yes our SA results are ordered by pft, then compartment. What we're plotting is ordered pft 0 leaf, pft 0 stem, pft 0 root, and so on.

We actually don't have any documentation for naming convention that I can find. I was thinking it actually was {variable}{pft}{compartment}, but that might be wrong. @Elchin can you confirm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants